GJL commented on a change in pull request #9860: [FLINK-14331][runtime] Reset 
vertices right after they transition to terminated states
URL: https://github.com/apache/flink/pull/9860#discussion_r333947428
 
 

 ##########
 File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionVertex.java
 ##########
 @@ -706,8 +706,10 @@ private Execution resetForNewExecutionInternal(final long 
timestamp, final long
 
        public void tryAssignResource(LogicalSlot slot) {
                if (!currentExecution.tryAssignResource(slot)) {
-                       throw new IllegalStateException("Could not assign 
resource " + slot + " to current execution " +
+                       final RuntimeException e = new 
IllegalStateException("Could not assign resource " + slot + " to current 
execution " +
 
 Review comment:
   nit: I have never seen this style before. I think I would just declare it as 
`IllegalStateException` but it's not important.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to