GJL commented on a change in pull request #9860: [FLINK-14331][runtime] Reset
vertices right after they transition to terminated states
URL: https://github.com/apache/flink/pull/9860#discussion_r334354868
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/DefaultScheduler.java
##########
@@ -246,23 +256,23 @@ public void allocateSlotsAndDeploy(final
Collection<ExecutionVertexDeploymentOpt
}
}
+ private void validateDeploymentOptions(final
Collection<ExecutionVertexDeploymentOption> deploymentOptions) {
+ deploymentOptions.stream()
+
.map(ExecutionVertexDeploymentOption::getExecutionVertexId)
+ .map(this::getExecutionVertex)
+ .map(ExecutionVertex::getExecutionState)
+ .forEach(state -> checkState(
+ state == ExecutionState.CREATED,
+ "vertex to schedule must be in CREATED state"));
Review comment:
I think it's better to also include the execution vertex id in the error
message, e.g., _"expected execution of vertex %s to be in CREATED state, was:
%s"_
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
