GJL commented on a change in pull request #9860: [FLINK-14331][runtime] Reset
vertices right after they transition to terminated states
URL: https://github.com/apache/flink/pull/9860#discussion_r334367314
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionVertex.java
##########
@@ -706,8 +706,10 @@ private Execution resetForNewExecutionInternal(final long
timestamp, final long
public void tryAssignResource(LogicalSlot slot) {
if (!currentExecution.tryAssignResource(slot)) {
- throw new IllegalStateException("Could not assign
resource " + slot + " to current execution " +
- currentExecution + '.');
+ final IllegalStateException e = new
IllegalStateException(
+ "Could not assign resource " + slot + " to
current execution " + currentExecution + '.');
+ slot.releaseSlot(e);
Review comment:
I am getting second thoughts about this change. It's not optimal that we are
adding business logic to the `ExecutionVertex`. I think it's better to let the
caller handle releasing the slot. Since this `IllegalStateException` denotes a
bug, what do you think about wrapping all instances of
`.handle(assignResourceOrHandleError(deploymentHandle))` into
`FutureUtils.assertNoException`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
