azagrebin commented on a change in pull request #9747: [FLINK-13985] Use unsafe 
memory for managed memory
URL: https://github.com/apache/flink/pull/9747#discussion_r334840922
 
 

 ##########
 File path: 
flink-core/src/test/java/org/apache/flink/core/memory/MemorySegmentChecksTest.java
 ##########
 @@ -39,29 +39,19 @@ public void testHeapNullBuffer2() {
                new HeapMemorySegment(null, new Object());
        }
 
-       @Test(expected = NullPointerException.class)
-       public void testHybridHeapNullBuffer1() {
-               new HybridMemorySegment((byte[]) null);
-       }
-
        @Test(expected = NullPointerException.class)
        public void testHybridHeapNullBuffer2() {
 
 Review comment:
   I guess `2` means two function arguments. We could remove it, I would keep 
to preserve the git history because the change is not really necessary.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to