azagrebin commented on a change in pull request #9747: [FLINK-13985] Use unsafe
memory for managed memory
URL: https://github.com/apache/flink/pull/9747#discussion_r334939812
##########
File path:
flink-core/src/test/java/org/apache/flink/core/memory/MemorySegmentChecksTest.java
##########
@@ -39,29 +39,19 @@ public void testHeapNullBuffer2() {
new HeapMemorySegment(null, new Object());
}
- @Test(expected = NullPointerException.class)
- public void testHybridHeapNullBuffer1() {
- new HybridMemorySegment((byte[]) null);
- }
-
@Test(expected = NullPointerException.class)
public void testHybridHeapNullBuffer2() {
Review comment:
True, we could do that. `2` means two function arguments, I guess. I just
wanted to preserve the git history for this line as these renamings are not
really necessary for this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
