zhuzhurk commented on a change in pull request #10076: [FLINK-14465][runtime]
Let `StandaloneJobClusterEntrypoint` use user code class loader
URL: https://github.com/apache/flink/pull/10076#discussion_r342418215
##########
File path:
flink-clients/src/main/java/org/apache/flink/client/program/PackagedProgram.java
##########
@@ -184,8 +184,6 @@ public PackagedProgram(File jarFile, List<URL> classpaths,
@Nullable String entr
}
checkJarFile(jarFileUrl);
- } else if (!isPython) {
- throw new IllegalArgumentException("The jar file must
not be null.");
Review comment:
If to do the rework in another ticket and keep the constructor public in
this PR, I think a check is needed to ensure the `entryPointClassName` and
`jarFile` are not null at the same time, otherwise an NPE would happen, as till
mentioned.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
