zhuzhurk commented on a change in pull request #10076: [FLINK-14465][runtime]
Let `StandaloneJobClusterEntrypoint` use user code class loader
URL: https://github.com/apache/flink/pull/10076#discussion_r342928270
##########
File path:
flink-container/src/test/java/org/apache/flink/container/entrypoint/ClassPathJobGraphRetrieverTest.java
##########
@@ -53,10 +68,69 @@
@Rule
public final TemporaryFolder temporaryFolder = new TemporaryFolder();
+ @ClassRule
+ public static final TemporaryFolder JOB_DIRS = new TemporaryFolder();
+
private static final String[] PROGRAM_ARGUMENTS = {"--arg", "suffix"};
+ /*
+ * The directory structure used to test
+ *
+ * userDirHasEntryClass/
+ * |_jarWithEntryClass
+ * |_jarWithoutEntryClass
+ * |_textFile
+ *
+ * userDirHasNotEntryClass/
+ * |_jarWithoutEntryClass
Review comment:
I guess not. It's also not aligned in IDE.
Looks to me it is using a mixture of tabs and spaces, and the last but one
char is a tab in the upper while it is a space in the lower.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
