zhuzhurk commented on a change in pull request #10079: [FLINK-14594] Fix
matching logics of ResourceSpec/ResourceProfile/Resource considering double
values
URL: https://github.com/apache/flink/pull/10079#discussion_r342953666
##########
File path:
flink-core/src/main/java/org/apache/flink/api/common/operators/ResourceSpec.java
##########
@@ -208,7 +207,15 @@ public double getGPUResource() {
* @param other The resource to compare
* @return True if current resource is less than or equal with the
other resource, otherwise return false.
*/
- public boolean lessThanOrEqual(@Nonnull ResourceSpec other) {
+ public boolean lessThanOrEqual(final ResourceSpec other) {
+ checkNotNull(other);
Review comment:
I guess not. In DataStreamSink it's doing some extra validations.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
