zhijiangW commented on a change in pull request #10083: [FLINK-14472][runtime]Implement back-pressure monitor with non-blocking outputs. URL: https://github.com/apache/flink/pull/10083#discussion_r344013614
########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutor.java ########## @@ -273,7 +276,11 @@ public TaskExecutor( this.resourceManagerConnection = null; this.currentRegistrationTimeoutId = null; - this.stackTraceSampleService = new StackTraceSampleService(rpcService.getScheduledExecutor()); + final Configuration config = taskManagerConfiguration.getConfiguration(); + this.taskBackPressureSampleService = new BackPressureSampleService( Review comment: I suggest constructing the `BackPressureSampleService` out of the constructor to make it clean, also we could avoid `taskManagerConfiguration.getConfiguration()` from outside call. It is elegant to prepare everything outside and then pass them directly into the constructor. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services