zhijiangW commented on a change in pull request #10083: [FLINK-14472][runtime]Implement back-pressure monitor with non-blocking outputs. URL: https://github.com/apache/flink/pull/10083#discussion_r344021232
########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/legacy/backpressure/BackPressureStats.java ########## @@ -0,0 +1,87 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.rest.handler.legacy.backpressure; + +import org.apache.flink.runtime.executiongraph.ExecutionAttemptID; + +import java.util.Collections; +import java.util.Map; + +import static org.apache.flink.util.Preconditions.checkArgument; + +/** + * Back pressure stats for one or more tasks. + * + * <p>The stats are collected by request triggered in {@link BackPressureRequestCoordinator}. + */ +public class BackPressureStats { + + /** ID of the request (unique per job). */ + private final int requestId; + + /** Time stamp, when the request was triggered. */ + private final long startTime; + + /** Time stamp, when all back pressure stats were collected at the JobManager. */ + private final long endTime; + + /** Map of back pressure ratio by execution ID. */ + private final Map<ExecutionAttemptID, Double> backPressureRatios; + + public BackPressureStats( + int requestId, + long startTime, + long endTime, + Map<ExecutionAttemptID, Double> backPressureRatios) { + + checkArgument(requestId >= 0, "Negative request ID."); + checkArgument(startTime >= 0, "Negative start time."); + checkArgument(endTime >= startTime, "End time before start time."); Review comment: I wonder it exists the case that `endTime = startTime`? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
