azagrebin commented on a change in pull request #10161: [FLINK-13986][runtime]
Clean up legacy code for FLIP-49.
URL: https://github.com/apache/flink/pull/10161#discussion_r347948175
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManager.java
##########
@@ -1207,7 +1207,7 @@ protected int getNumberRequiredTaskManagerSlots() {
public static Collection<ResourceProfile>
createWorkerSlotProfiles(Configuration config) {
final int numSlots =
config.getInteger(TaskManagerOptions.NUM_TASK_SLOTS);
- final long managedMemoryBytes =
MemorySize.parse(config.getString(TaskManagerOptions.LEGACY_MANAGED_MEMORY_SIZE)).getBytes();
+ final long managedMemoryBytes =
MemorySize.parse(config.getString(TaskManagerOptions.MANAGED_MEMORY_SIZE,
"0b")).getBytes();
Review comment:
ok, thanks for explanation. I would still try to remove
`ActiveResourceManagerFactory/Test` and keep hack inside
`createWorkerSlotProfiles`. E.g. set heap managed memory as a sum of
heap/off-heap (with a detailed explaining comment referencing the follow-up
issue) but from `TaskExecutorResourceSpec`, not by adjusted config in
`ActiveResourceManagerFactory`, this looks confusing, IMO.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
