godfreyhe commented on a change in pull request #10174: [FLINK-14625][table-planner-blink] Add a rule to eliminate cross join as much as possible without statistics URL: https://github.com/apache/flink/pull/10174#discussion_r349981321
########## File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/plan/optimize/program/FlinkBatchProgram.scala ########## @@ -139,24 +140,24 @@ object FlinkBatchProgram { // join reorder val deprecatedJoinReorderEnabled = config.getBoolean(OptimizerConfigOptions.TABLE_OPTIMIZER_JOIN_REORDER_ENABLED) - val joinReorderMode = JoinReorderMode.withName( - config.getString(OptimizerConfigOptions.TABLE_OPTIMIZER_JOIN_REORDER_MODE)) + val joinReorderMode = JoinReorderStrategy.valueOf( Review comment: rename to `joinReorderStrategy` ? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services