zjuwangg commented on a change in pull request #10296: [FLINK-14691][table]Add use/create/drop/alter database operation and support it in flink/blink planner URL: https://github.com/apache/flink/pull/10296#discussion_r349987842
########## File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/client/HiveMetastoreClientWrapper.java ########## @@ -149,6 +149,11 @@ public void dropDatabase(String name, boolean deleteData, boolean ignoreIfNotExi client.dropDatabase(name, deleteData, ignoreIfNotExists); } + public void dropDatabase(String name, boolean deleteData, boolean ignoreIfNotExists, boolean cascade) + throws NoSuchObjectException, InvalidOperationException, MetaException, TException { + client.dropDatabase(name, deleteData, ignoreIfNotExists, cascade); Review comment: Yes,I check it hive version's range in [1.0.0, 3.1.2], all of them support this method. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services