xintongsong commented on a change in pull request #10146:
[FLINK-14188][runtime] TaskExecutor derive and register with default slot
resource profile
URL: https://github.com/apache/flink/pull/10146#discussion_r351179857
##########
File path:
flink-core/src/main/java/org/apache/flink/configuration/TaskManagerOptions.java
##########
@@ -136,6 +138,20 @@
" is typically proportional to the number of
physical CPU cores that the TaskManager's machine has" +
" (e.g., equal to the number of cores, or half
the number of cores).");
+ /**
+ * Fraction of TaskExecutor resources a default slot should take for
slot requests with unknown resource profiles.
+ */
+ @Documentation.CommonOption(position =
Documentation.CommonOption.POSITION_PARALLELISM_SLOTS)
+ public static final ConfigOption<Float> DEFAULT_SLOT_FRACTION =
+ key("taskmanager.default-slot-fraction")
+ .defaultValue(-1.0f)
Review comment:
As discussed offline, I'll set this config option to no default value, so we
do not accidentally forget to check whether it is explicitly configured and
fail to fallback to the legacy number of slots. Also we will not use negative
values to represent "not specified".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
