xintongsong commented on a change in pull request #10146: [FLINK-14188][runtime] TaskExecutor derive and register with default slot resource profile URL: https://github.com/apache/flink/pull/10146#discussion_r352409568
########## File path: flink-core/src/main/java/org/apache/flink/configuration/TaskManagerOptions.java ########## @@ -217,9 +217,22 @@ .build()); // ------------------------------------------------------------------------ - // Memory Options + // Resource Options // ------------------------------------------------------------------------ + /** + * This config key is used for passing cpu cores into TaskExecutors. Review comment: True. I forgot to update the javadoc when changing it from a non-public config key to a public config option. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services