xintongsong commented on a change in pull request #10146:
[FLINK-14188][runtime] TaskExecutor derive and register with default slot
resource profile
URL: https://github.com/apache/flink/pull/10146#discussion_r352426163
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/clusterframework/TaskExecutorResourceUtilsTest.java
##########
@@ -556,6 +559,82 @@ public void testConfigTotalProcessMemoryAddUpFailure() {
validateFail(conf);
}
+ @Test
+ public void testConfigDefaultSlotFraction() {
+ final double defaultSlotFraction = 0.5;
+
+ Configuration conf = new Configuration();
+ conf.setDouble(TaskManagerOptions.DEFAULT_SLOT_FRACTION,
(float) defaultSlotFraction);
+
+ validateInAllConfigurations(conf, taskExecutorResourceSpec -> {
Review comment:
The next test is for validating backwards compatibility of the legacy number
of slot config option.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
