carp84 commented on a change in pull request #10329:
[FLINK-12785][StateBackend] RocksDB savepoint recovery can use a lot of
unmanaged memory
URL: https://github.com/apache/flink/pull/10329#discussion_r353669265
##########
File path:
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBStateBackend.java
##########
@@ -166,6 +169,11 @@
/** Whether we already lazily initialized our local storage
directories. */
private transient boolean isInitialized;
+ /**
+ * Max consumed memory size for one batch in {@link
RocksDBWriteBatchWrapper}, default value 2mb.
+ */
+ private long batchSize;
Review comment:
Suggest to change all "batchSize/BATCH_SIZE" to
"writeBatchSize/WRITE_BATCH_SIZE" in this class.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
