Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1255#discussion_r43953613
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/operators/shipping/OutputEmitter.java
---
@@ -135,7 +116,7 @@ public OutputEmitter(ShipStrategyType strategy,
TypeComparator<T> comparator, Pa
case PARTITION_CUSTOM:
return customPartition(record.getInstance(),
numberOfChannels);
case PARTITION_RANGE:
- return rangePartition(record.getInstance(),
numberOfChannels);
+ return rangePartition((Tuple2<Integer,
?>)record.getInstance(), numberOfChannels);
--- End diff --
I would not make the `OutputEmitter` type specific, i.e., expect a
`Tuple2<Integer, ?>`. Instead I would use a Integer DataDistribution, and a
`TypeComparator<Tuple2<Integer,?>` that compares on field `f0`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
