Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1255#discussion_r43956876
  
    --- Diff: 
flink-java/src/main/java/org/apache/flink/api/java/operators/PartitionOperator.java
 ---
    @@ -148,9 +147,6 @@ else if (pKeys instanceof Keys.SelectorFunctionKeys) {
                        }
                        
                } 
    -           else if (pMethod == PartitionMethod.RANGE) {
    --- End diff --
    
    We need to add a check here to ensure that 
`pKeys.getKeyType().isSortKeyType() == true`. The reason for this is that some 
keys can be used for grouping but not for sorting because their order is not 
well defined. For example POJO types have multiple fields on which they can be 
grouped, but the order of their fields is not defined so the order of POJO 
objects isn't defined either.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to