hequn8128 commented on a change in pull request #10086: [FLINK-14584][python] Support complex data types in Python user-defined functions URL: https://github.com/apache/flink/pull/10086#discussion_r354643597
########## File path: flink-python/src/main/java/org/apache/flink/table/runtime/typeutils/serializers/python/BaseMapSerializer.java ########## @@ -0,0 +1,214 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.runtime.typeutils.serializers.python; + +import org.apache.flink.annotation.Internal; +import org.apache.flink.api.common.typeutils.TypeSerializer; +import org.apache.flink.api.common.typeutils.TypeSerializerSchemaCompatibility; +import org.apache.flink.api.common.typeutils.TypeSerializerSnapshot; +import org.apache.flink.api.java.typeutils.runtime.DataInputViewStream; +import org.apache.flink.api.java.typeutils.runtime.DataOutputViewStream; +import org.apache.flink.core.memory.DataInputView; +import org.apache.flink.core.memory.DataOutputView; +import org.apache.flink.table.dataformat.BaseMap; +import org.apache.flink.table.dataformat.BinaryArray; +import org.apache.flink.table.dataformat.BinaryArrayWriter; +import org.apache.flink.table.dataformat.BinaryMap; +import org.apache.flink.table.dataformat.BinaryWriter; +import org.apache.flink.table.dataformat.TypeGetterSetters; +import org.apache.flink.table.types.logical.LogicalType; +import org.apache.flink.util.InstantiationUtil; + +import java.io.IOException; + +/** + * A {@link TypeSerializer} for {@link BaseMap}. It should be noted that the header will not be + * encoded. Currently Python doesn't support BinaryMap natively, so we can't use BaseArraySerializer + * in blink directly. + */ +@Internal +public class BaseMapSerializer extends org.apache.flink.table.runtime.typeutils.BaseMapSerializer { + + private static final long serialVersionUID = 1L; + + private final LogicalType keyType; + + private final LogicalType valueType; + + private final TypeSerializer keyTypeSerializer; + + private final TypeSerializer valueTypeSerializer; + + private final int keySize; + + private final int valueSize; + + public BaseMapSerializer(LogicalType keyType, LogicalType valueType + , TypeSerializer keyTypeSerializer, TypeSerializer valueTypeSerializer) { + super(keyType, valueType, null); + this.keyType = keyType; + this.valueType = valueType; + this.keyTypeSerializer = keyTypeSerializer; + this.valueTypeSerializer = valueTypeSerializer; + this.keySize = BinaryArray.calculateFixLengthPartSize(this.keyType); + this.valueSize = BinaryArray.calculateFixLengthPartSize(this.valueType); + } + + @Override + public void serialize(BaseMap map, DataOutputView target) throws IOException { + BinaryMap binaryMap = (BinaryMap) map; Review comment: The BaseMap map can be a GenericMap. Take a look at the `public BaseMap copy(BaseMap from)` method in the Base class(org.apache.flink.table.runtime.typeutils.BaseMapSerializer) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
