hequn8128 commented on a change in pull request #10086: [FLINK-14584][python] Support complex data types in Python user-defined functions URL: https://github.com/apache/flink/pull/10086#discussion_r354646786
########## File path: flink-python/src/main/java/org/apache/flink/table/runtime/typeutils/serializers/python/BaseArraySerializer.java ########## @@ -0,0 +1,177 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.runtime.typeutils.serializers.python; + +import org.apache.flink.annotation.Internal; +import org.apache.flink.api.common.typeutils.TypeSerializer; +import org.apache.flink.api.common.typeutils.TypeSerializerSchemaCompatibility; +import org.apache.flink.api.common.typeutils.TypeSerializerSnapshot; +import org.apache.flink.api.java.typeutils.runtime.DataInputViewStream; +import org.apache.flink.api.java.typeutils.runtime.DataOutputViewStream; +import org.apache.flink.core.memory.DataInputView; +import org.apache.flink.core.memory.DataOutputView; +import org.apache.flink.table.dataformat.BaseArray; +import org.apache.flink.table.dataformat.BinaryArray; +import org.apache.flink.table.dataformat.BinaryArrayWriter; +import org.apache.flink.table.dataformat.BinaryWriter; +import org.apache.flink.table.dataformat.TypeGetterSetters; +import org.apache.flink.table.types.logical.LogicalType; +import org.apache.flink.util.InstantiationUtil; + +import java.io.IOException; + +/** + * A {@link TypeSerializer} for {@link BaseArray}. It should be noted that the header will not be + * encoded. Currently Python doesn't support BinaryArray natively, so we can't use BaseArraySerializer + * in blink directly. + */ +@Internal +public class BaseArraySerializer extends org.apache.flink.table.runtime.typeutils.BaseArraySerializer { + + private static final long serialVersionUID = 1L; + + private final LogicalType elementType; + + private final TypeSerializer elementTypeSerializer; + + private final int elementSize; + + public BaseArraySerializer(LogicalType eleType, TypeSerializer elementTypeSerializer) { + super(eleType, null); + this.elementType = eleType; + this.elementTypeSerializer = elementTypeSerializer; + this.elementSize = BinaryArray.calculateFixLengthPartSize(this.elementType); + } + + @Override + public void serialize(BaseArray array, DataOutputView target) throws IOException { + int len = array.numElements(); + target.writeInt(len); + for (int i = 0; i < len; i++) { + if (array.isNullAt(i)) { + target.writeBoolean(false); + } else { + target.writeBoolean(true); + Object element = TypeGetterSetters.get(array, i, elementType); + elementTypeSerializer.serialize(element, target); + } + } + } + + @Override + public BaseArray deserialize(DataInputView source) throws IOException { + int len = source.readInt(); + BinaryArray array = new BinaryArray(); + BinaryArrayWriter writer = new BinaryArrayWriter(array, len, elementSize); + for (int i = 0; i < len; i++) { + boolean isNonNull = source.readBoolean(); + if (isNonNull) { + Object element = elementTypeSerializer.deserialize(source); + BinaryWriter.write(writer, i, element, elementType, elementTypeSerializer); + } else { + writer.setNullAt(i); + } + } + writer.complete(); + return array; + } + + @Override + public BaseArray deserialize(BaseArray reuse, DataInputView source) throws IOException { + return deserialize(source); + } + + @Override + public void copy(DataInputView source, DataOutputView target) throws IOException { + serialize(deserialize(source), target); + } + + @Override + public TypeSerializer<BaseArray> duplicate() { + return new BaseArraySerializer(elementType, elementTypeSerializer); + } + + @Override + public TypeSerializerSnapshot<BaseArray> snapshotConfiguration() { + return new BaseArraySerializerSnapshot(elementType, elementTypeSerializer); + } + + /** + * {@link TypeSerializerSnapshot} for {@link BaseArraySerializer}. + */ + public static final class BaseArraySerializerSnapshot implements TypeSerializerSnapshot<BaseArray> { + private static final int CURRENT_VERSION = 3; Review comment: Current version to 1? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
