KurtYoung commented on a change in pull request #10454:
[FLINK-13195][sql-client] Add create(drop) table support for SqlClient
URL: https://github.com/apache/flink/pull/10454#discussion_r354683869
##########
File path:
flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/local/ExecutionContext.java
##########
@@ -428,6 +485,12 @@ private void initializeTableEnvironment() {
modules.forEach(tableEnv::loadModule);
}
+ if (catalogManager != null) {
Review comment:
I think you can split the logic into 2 groups:
1. initializing this with previous catalog manager
2. initializing this without previous catalog manager
and do a if-else here. Step 3-6 can be extracted to a new init catalog method
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
