KurtYoung commented on a change in pull request #10454:
[FLINK-13195][sql-client] Add create(drop) table support for SqlClient
URL: https://github.com/apache/flink/pull/10454#discussion_r354685477
##########
File path:
flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/local/ExecutionContext.java
##########
@@ -154,8 +160,29 @@ public ExecutionContext(
ClusterClientServiceLoader clusterClientServiceLoader,
Options commandLineOptions,
List<CustomCommandLine> availableCommandLines) throws
FlinkException {
+ this(
+ environment,
+ originalSessionContext,
+ null,
+ dependencies,
+ flinkConfig,
+ new DefaultClusterClientServiceLoader(),
+ commandLineOptions,
+ availableCommandLines);
+ }
+
+ public ExecutionContext(
Review comment:
make all constructors `private` if you want to introduce `Builder`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
