wuchong commented on a change in pull request #10536: [FLINK-15191][connectors
/ kafka]Fix can't create table source for Kafka if watermark or computed column
is defined.
URL: https://github.com/apache/flink/pull/10536#discussion_r357505704
##########
File path:
flink-table/flink-table-common/src/main/java/org/apache/flink/table/sources/TableSourceValidation.java
##########
@@ -59,7 +60,7 @@
* @param tableSource The {@link TableSource} for which the time
attributes are checked.
*/
public static void validateTableSource(TableSource<?> tableSource){
- TableSchema schema = tableSource.getTableSchema();
+ TableSchema schema =
TableSchemaUtils.filterGeneratedColumn(tableSource.getTableSchema());
Review comment:
Should trust schema from users.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
