wuchong commented on a change in pull request #10536: [FLINK-15191][connectors / kafka]Fix can't create table source for Kafka if watermark or computed column is defined. URL: https://github.com/apache/flink/pull/10536#discussion_r358042505
########## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/utils/TableSchemaUtils.java ########## @@ -0,0 +1,57 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.utils; + +import org.apache.flink.annotation.Internal; +import org.apache.flink.table.api.TableColumn; +import org.apache.flink.table.api.TableSchema; +import org.apache.flink.table.sinks.TableSink; +import org.apache.flink.table.sources.TableSource; +import org.apache.flink.util.Preconditions; + +/** + * Utilities to deal physical {@link TableColumn} from {@link TableSchema}. + */ +@Internal +public class TableSchemaUtils { + + /** + * Return {@link TableSchema} which consist of all physical columns. + * Constructor of {@link TableSource} and {@link TableSink} should call this method. + */ + public static TableSchema getPhysicalTableSchema(TableSchema tableSchema) { + Preconditions.checkNotNull(tableSchema); + TableSchema.Builder builder = new TableSchema.Builder(); + tableSchema.getTableColumns().stream().forEach( + tableColumn -> { + if (!tableColumn.isGenerated()) { + builder.field(tableColumn.getName(), tableColumn.getType()); + } + }); + return builder.build(); + } + + /** + * Returns whether there only contains the physical {@link TableColumn}. + */ + public static boolean containsOnlyPhysicalColumn(TableSchema tableSchema) { + Preconditions.checkNotNull(tableSchema); + return tableSchema.getTableColumns().stream().noneMatch(tableColumn -> tableColumn.isGenerated()); Review comment: `tableColumn -> tableColumn.isGenerated()` -> `TableColumn::isGenerated`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
