wuchong commented on a change in pull request #10536: [FLINK-15191][connectors
/ kafka]Fix can't create table source for Kafka if watermark or computed column
is defined.
URL: https://github.com/apache/flink/pull/10536#discussion_r358046608
##########
File path:
flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/api/TableUtils.java
##########
@@ -100,7 +101,7 @@
* for external output.
*/
private static TableSchema buildNewTableSchema(Table table) {
- TableSchema oldSchema = table.getSchema();
+ TableSchema oldSchema =
TableSchemaUtils.getPhysicalTableSchema(table.getSchema());
Review comment:
I think we shouldn't change this line. The schema of `Table` may contains
generated columns, but the generated column should also be outputed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
