JingsongLi commented on a change in pull request #10625: [FLINK-15259][hive] HiveInspector.toInspectors() should convert Flink… URL: https://github.com/apache/flink/pull/10625#discussion_r362160039
########## File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/codegen/GenerateUtils.scala ########## @@ -375,7 +375,7 @@ object GenerateUtils { | $SQL_TIMESTAMP.fromEpochMillis(${ts.getMillisecond}L, ${ts.getNanoOfMillisecond}); """.stripMargin ctx.addReusableMember(fieldTimestamp) - generateNonNullLiteral(literalType, fieldTerm, literalType) + generateNonNullLiteral(literalType, fieldTerm, ts) Review comment: Don't mix the planner's single line modification with hive's modification, and there is no test. You should add a single commit to explain why we need it and what is this bug. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services