lirui-apache commented on a change in pull request #10625: [FLINK-15259][hive] 
HiveInspector.toInspectors() should convert Flink…
URL: https://github.com/apache/flink/pull/10625#discussion_r361938203
 
 

 ##########
 File path: 
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/client/HiveShimV310.java
 ##########
 @@ -233,4 +240,23 @@ public LocalDate toFlinkDate(Object hiveDate) {
                        throw new FlinkHiveException("Failed to convert to 
Flink date", e);
                }
        }
+
+       @Override
+       public Writable hivePrimitiveToWritable(Object value) throws 
CatalogException {
+               try {
+                       return super.hivePrimitiveToWritable(value);
+               } catch (CatalogException e) {
 
 Review comment:
   Maybe I can use optional. Let me have a try

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to