dawidwys commented on a change in pull request #10763: [FLINK-14200][table] Fix
NPE for Temporal Table Function Join when left side is a query instead of a
source
URL: https://github.com/apache/flink/pull/10763#discussion_r363202235
##########
File path:
flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/plan/stream/sql/join/TemporalJoinTest.scala
##########
@@ -73,6 +73,21 @@ class TemporalJoinTest extends TableTestBase {
util.verifyPlan(sqlQuery)
}
+ @Test
+ def testJoinOnQueryLeft(): Unit = {
+ val orders = util.tableEnv.sqlQuery("SELECT * FROM Orders WHERE o_amount >
1000")
+ // register a query as left side
Review comment:
nit: this comment is a bit misleading don't you think? It depends on the
subsequent query what will be the view used for.
Anyway it does not provide any extra info therefore personally I'm always
against adding redundant comments as they easily go out of sync.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
