wuchong commented on a change in pull request #10989:
[FLINK-15840][table-planner-blink] ClassCastException is thrown when use
tEnv.from for temp/catalog table
URL: https://github.com/apache/flink/pull/10989#discussion_r373846595
##########
File path:
flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/plan/batch/sql/TableScanTest.scala
##########
@@ -68,12 +70,15 @@ class TableScanTest extends TableTestBase {
| 'is-bounded' = 'true'
|)
""".stripMargin)
- util.verifyPlan("SELECT * FROM t1")
}
-
@Test
- def testDDLWithWatermarkComputedColumn(): Unit = {
+ def testDDLWithComputedColumn(): Unit = {
+ prepareComputedColumnDDL()
+ util.verifyPlan("SELECT * FROM t1")
+ }
+
+ private def prepareWatermarkDDL(): Unit = {
Review comment:
Can we move the `prepareWatermarkDDL` and `prepareComputedColumnDDL` to the
before stage and give the tables a more readable name, e.g.
`computed_column_tbl`, `watermark_tbl`? So that the tests doens't need to
invoke these methods.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
