JingsongLi commented on a change in pull request #10989: [FLINK-15840][table-planner-blink] ClassCastException is thrown when use tEnv.from for temp/catalog table URL: https://github.com/apache/flink/pull/10989#discussion_r373898790
########## File path: flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/delegation/PlannerContext.java ########## @@ -109,6 +109,9 @@ public PlannerContext( planner.addRelTraitDef(traitDef); } this.cluster = FlinkRelOptClusterFactory.create(planner, new RexBuilder(typeFactory)); + + this.context.toRexConverterFactory_$eq(t -> new SqlExprToRexConverterImpl( Review comment: It is factory now, we can just remove `final` of `frameworkConfig` and `cluster`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services