zentol commented on a change in pull request #10995: [FLINK-15847][ml] Include 
flink-ml-api and flink-ml-lib in opt
URL: https://github.com/apache/flink/pull/10995#discussion_r379444141
 
 

 ##########
 File path: flink-dist/src/main/assemblies/opt.xml
 ##########
 @@ -168,6 +168,14 @@
                        
<destName>flink-python_${scala.binary.version}-${project.version}.jar</destName>
                        <fileMode>0644</fileMode>
                </file>
+
+               <!-- ML (API & LIB)  -->
+               <file>
 
 Review comment:
   I agree that there should be an uber module. The current packaging also 
appears to be incorrect since flink-ml-api is _not_ bundled in flink-ml-lib 
anyway.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to