zentol commented on a change in pull request #10995: [FLINK-15847][ml] Include flink-ml-api and flink-ml-lib in opt URL: https://github.com/apache/flink/pull/10995#discussion_r379933502
########## File path: flink-ml-parent/flink-ml-lib/pom.xml ########## @@ -57,4 +57,30 @@ under the License. <version>1.1.2</version> </dependency> </dependencies> + + <build> + <plugins> + <!-- Build flink-ml-lib jar --> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-shade-plugin</artifactId> + <executions> + <execution> + <id>shade-flink</id> + <phase>package</phase> + <goals> + <goal>shade</goal> + </goals> + <configuration> + <artifactSet> + <includes combine.children="append"> + <include>com.github.fommil.netlib:core</include> Review comment: If the dependency is not bundled in 1.10 then yes, the licensing part of the commit should be reverted. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services