AHeise commented on a change in pull request #11123: [FLINK-16014][s3] Force
usage of SAXParserFactory over XMLReaderFactory in aws-java-sdk-s3.
URL: https://github.com/apache/flink/pull/11123#discussion_r387881168
##########
File path: flink-filesystems/flink-s3-fs-base/pom.xml
##########
@@ -231,6 +231,33 @@ under the License.
<skip>true</skip>
</configuration>
</plugin>
+
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-shade-plugin</artifactId>
Review comment:
Unfortunately, it's not that easy. If it's a parent project, it needs to be
of type pom and cannot ship code by default.
There is a
[workaround](https://stackoverflow.com/questions/12305190/how-to-generate-jar-for-maven-parent-project),
but it's certainly adding some complexity.
The cleanest solution would be to add another module just for the pom, but
that's also more complex than I'd like it to be.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
