AHeise commented on a change in pull request #11123: [FLINK-16014][s3] Force 
usage of SAXParserFactory over XMLReaderFactory in aws-java-sdk-s3.
URL: https://github.com/apache/flink/pull/11123#discussion_r388503914
 
 

 ##########
 File path: flink-filesystems/flink-s3-fs-base/pom.xml
 ##########
 @@ -231,6 +231,33 @@ under the License.
                                        <skip>true</skip>
                                </configuration>
                        </plugin>
+
+                       <plugin>
+                               <groupId>org.apache.maven.plugins</groupId>
+                               <artifactId>maven-shade-plugin</artifactId>
 
 Review comment:
   Not sure what you mean but `flink-s3-fs-base` has code that is lost when I 
change packaging to `pom`, which in turn is required for parent projects.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to