wuchong commented on a change in pull request #11296: [FLINK-16363] [table]
Correct the execution behavior of TableEnvironment and StreamTableEnvironment
URL: https://github.com/apache/flink/pull/11296#discussion_r388756941
##########
File path:
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/TableEnvironmentImpl.java
##########
@@ -763,10 +738,14 @@ protected void validateTableSource(TableSource<?>
tableSource) {
TableSourceValidation.validateTableSource(tableSource,
tableSource.getTableSchema());
}
- private void translate(List<ModifyOperation> modifyOperations) {
- List<Transformation<?>> transformations =
planner.translate(modifyOperations);
+ protected List<Transformation<?>> translate() {
Review comment:
rename this method to `translateAndClear()` to make the clear behavior more
explicitly?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
