TisonKun commented on a change in pull request #11296: [FLINK-16363] [table]
Correct the execution behavior of TableEnvironment and StreamTableEnvironment
URL: https://github.com/apache/flink/pull/11296#discussion_r389049976
##########
File path:
flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/delegation/ExecutorBase.java
##########
@@ -43,25 +42,16 @@ public ExecutorBase(StreamExecutionEnvironment
executionEnvironment) {
this.executionEnvironment = executionEnvironment;
}
- public void setTableConfig(TableConfig tableConfig) {
- this.tableConfig = tableConfig;
- }
-
public StreamExecutionEnvironment getExecutionEnvironment() {
return executionEnvironment;
}
@Override
- public void apply(List<Transformation<?>> transformations) {
- transformations.forEach(getExecutionEnvironment()::addOperator);
+ public JobExecutionResult execute(Pipeline pipeline) throws Exception {
+ return executionEnvironment.execute((StreamGraph) pipeline);
}
- /**
- * Translates the transformations applied into this executor to a
stream graph.
- */
- public abstract StreamGraph getStreamGraph(String jobName);
-
- protected String getNonEmptyJobName(String jobName) {
+ String getNonEmptyJobName(String jobName) {
Review comment:
Why shall we change visibility? If for `VisitingForTesting`, annotate it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
