xintongsong commented on a change in pull request #11353: [FLINK-16438][yarn]
Make YarnResourceManager starts workers using WorkerResourceSpec requested by
SlotManager
URL: https://github.com/apache/flink/pull/11353#discussion_r390738660
##########
File path:
flink-yarn/src/test/java/org/apache/flink/yarn/YarnResourceManagerTest.java
##########
@@ -584,6 +590,85 @@ public void testGetCpuExceedMaxInt() throws Exception {
}};
}
+ @Test
+ public void testWorkerSpecContainerResourceAdapter_MatchVcores() {
Review comment:
I'm sure about this either. That's why I kept it, for discussions in the PR.
On one hand, I do find the following in the [code style
guide](https://flink.apache.org/contributing/code-style-and-quality-formatting.html).
> Non-static fields/methods must be in lower camel case.
On the other hand, the underscores do provide better readability in the long
test case name, and there are already test cases using them (e.g.,
MiniClusterConfigurationTest, CatalogTest, etc.).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
