KarmaGYZ commented on a change in pull request #11353: [FLINK-16438][yarn] Make YarnResourceManager starts workers using WorkerResourceSpec requested by SlotManager URL: https://github.com/apache/flink/pull/11353#discussion_r390751400
########## File path: flink-yarn/src/test/java/org/apache/flink/yarn/YarnResourceManagerTest.java ########## @@ -584,6 +590,85 @@ public void testGetCpuExceedMaxInt() throws Exception { }}; } + @Test + public void testWorkerSpecContainerResourceAdapter_MatchVcores() { Review comment: I prefer to follow the code style guide if possible but I'm ok with it atm. Someone who has better English proficiency may give us another idea about the name. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services