WeiZhong94 commented on a change in pull request #11238: [FLINK-16304][python]
Remove python packages bundled in the flink-python jar.
URL: https://github.com/apache/flink/pull/11238#discussion_r390920672
##########
File path: tools/releasing/collect_license_files.sh
##########
@@ -57,4 +57,19 @@ LICENSES="${DST}/licenses"
[ -f "${LICENSES}" ] && rm -r "${LICENSES}"
find "${TMP}" -name "licenses" -type d -exec cp -r -- "{}" "${DST}" \;
+# Search the source directory and collect those license files that
+# not bundled in any jars but exist in binary distribution.
+# The root license directory, hidden directories, docs, node.js should be
excluded.
+# The file name should be "LICENSE.PROJECT_NAME", so the license files with
incorrect
+# file names will be excluded.
+find "${SRC}" -name "LICENSE.*" -type f \
+! -path "*/.*/*" \
+! -path "*/target/*" \
+! -path "*/licenses/*" \
+! -path "*/docs/*" \
+! -path "*/flink-runtime-web/web-dashboard/node*/*" \
+! -path "*.txt" \
Review comment:
This is because there are many LICENSE.txt file in our source directory
which need to be excluded. As the latest commit change to search the binary
distribution, this line is not necessary anymore.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
