WeiZhong94 commented on a change in pull request #11238: [FLINK-16304][python]
Remove python packages bundled in the flink-python jar.
URL: https://github.com/apache/flink/pull/11238#discussion_r390988392
##########
File path: tools/releasing/collect_license_files.sh
##########
@@ -57,4 +57,9 @@ LICENSES="${DST}/licenses"
[ -f "${LICENSES}" ] && rm -r "${LICENSES}"
find "${TMP}" -name "licenses" -type d -exec cp -r -- "{}" "${DST}" \;
+# Search the binary distribution directory and collect those license files that
+# not bundled in any jars.
+find "${SRC}/flink-dist/target" -name "LICENSE.*" -type f \
+-path "*/flink-*-bin/*" ! -path "*/licenses/*" -exec cp -- "{}"
"${DST}/licenses" \;
Review comment:
+1 for the 1st and 2nd comments. For 3rd comments I'm not sure it is a good
idea, because "move" is not a idempotent and safe operation. If someone run
this script multiple times the results may not be what they expected. If
someone run this script in other directories, there may be unexpected
consequences, such as the strange disappearance of many files.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
