GJL commented on a change in pull request #11250: [FLINK-16302][rest]add log list and read log by name for taskmanager URL: https://github.com/apache/flink/pull/11250#discussion_r391815230
########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManager.java ########## @@ -582,16 +582,41 @@ public void notifySlotAvailable( } @Override - public CompletableFuture<TransientBlobKey> requestTaskManagerFileUpload(ResourceID taskManagerId, FileType fileType, Time timeout) { - log.debug("Request file {} upload from TaskExecutor {}.", fileType, taskManagerId); + public CompletableFuture<TransientBlobKey> requestTaskManagerFileUploadByType(ResourceID taskManagerId, FileType fileType, Time timeout) { + log.debug("Request file which type is {} upload from TaskExecutor {}.", fileType, taskManagerId); final WorkerRegistration<WorkerType> taskExecutor = taskExecutors.get(taskManagerId); if (taskExecutor == null) { - log.debug("Requested file {} upload from unregistered TaskExecutor {}.", fileType, taskManagerId); + log.debug("Requested which type is {} upload from unregistered TaskExecutor {}.", fileType, taskManagerId); Review comment: ``` log.debug("Request upload of log file {} from TaskExecutor {}.", fileType, taskManagerId); ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services