GJL commented on a change in pull request #11250: [FLINK-16302][rest]add log
list and read log by name for taskmanager
URL: https://github.com/apache/flink/pull/11250#discussion_r391819491
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/resourcemanager/utils/TestingResourceManagerGateway.java
##########
@@ -309,6 +317,26 @@ public void disconnectJobManager(JobID jobId, Exception
cause) {
}
}
+ @Override
+ public CompletableFuture<TransientBlobKey>
requestTaskManagerFileUploadByName(ResourceID taskManagerId, String fileName,
Time timeout) {
+ final Function<Tuple2<ResourceID, String>,
CompletableFuture<TransientBlobKey>> function =
requestTaskManagerFileUploadByNameFunction;
+
+ if (function != null) {
+ return function.apply(Tuple2.of(taskManagerId,
fileName));
+ } else {
+ return CompletableFuture.completedFuture(new
TransientBlobKey());
+ }
+ }
+
+ @Override
+ public CompletableFuture<Collection<Tuple2<String, Long>>>
requestTaskManagerLogList(ResourceID taskManagerId, Time timeout) {
+ List<Tuple2<String, Long>> logsList = new ArrayList<>();
Review comment:
This is not consistent with the other implementations. Moreover, we are not
testing the handler's behavior if an exception is thrown by the gateway.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
