danny0405 commented on a change in pull request #11340: [Flink 14338] Upgrade
Calcite version to 1.22 for Flink SQL
URL: https://github.com/apache/flink/pull/11340#discussion_r392009665
##########
File path:
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/operations/PlannerQueryOperation.java
##########
@@ -43,11 +44,22 @@ public PlannerQueryOperation(RelNode calciteTree) {
RelDataType rowType = calciteTree.getRowType();
String[] fieldNames = rowType.getFieldNames().toArray(new
String[0]);
- TypeInformation[] fieldTypes = rowType.getFieldList()
+ DataType[] fieldTypes = rowType.getFieldList()
Review comment:
I did this change to fix the tests in `LocalExecutorITCase#testViews`,
actually i have no idea why the old code base have the correct nullability
inference, but based on the current code base, the nullability inference is as
expected, and i fix them for `flink-planner`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
