danny0405 commented on a change in pull request #11340: [Flink 14338] Upgrade 
Calcite version to 1.22 for Flink SQL
URL: https://github.com/apache/flink/pull/11340#discussion_r393551828
 
 

 ##########
 File path: flink-table/flink-sql-parser/pom.xml
 ##########
 @@ -156,6 +174,12 @@ under the License.
                        <scope>test</scope>
                        <type>test-jar</type>
                </dependency>
+               <dependency>
+                       <groupId>org.junit.jupiter</groupId>
+                       <artifactId>junit-jupiter-engine</artifactId>
 
 Review comment:
   Because Calcite tests use Junit5 and we extend from it's `SqlParserTest`, 
add this dependency to make Junit4 tests compatible with Junit5 environment.
   
   I would add some comments.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to