danny0405 commented on a change in pull request #11340: [Flink 14338] Upgrade
Calcite version to 1.22 for Flink SQL
URL: https://github.com/apache/flink/pull/11340#discussion_r393555731
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/plan/nodes/logical/FlinkLogicalCalc.scala
##########
@@ -39,15 +42,19 @@ import java.util.function.Supplier
class FlinkLogicalCalc(
cluster: RelOptCluster,
traitSet: RelTraitSet,
+ hints: JList[RelHint],
Review comment:
I don't think there are any confuse, we should always keep the constructor
to have the full parameters, the old constructor is deprecated. We should avoid
to use the deprecated interfaces.
We rarely use the constructors directly in our code, usually we use the
RelBuilder instead. So it is better to implement these logical nodes hints
correctly, in the future, if we introduce any planner hints, these nodes still
works.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
