zhijiangW opened a new pull request #11441: [FLINK-16653][network][tests] 
Introduce ResultPartitionWriterTestBase for simplifying tests
URL: https://github.com/apache/flink/pull/11441
 
 
   ## What is the purpose of the change
   
   At the moment there are at-least four implementations of 
`ResultPartitionWriter` interface used in unit tests. And there are about ten 
methods to be implemented for `ResultPartitionWriter` and most of them are 
dummy in tests.
   
   When we want to extend the methods for `ResultPartitionWriter`, the above 
four dummy implementations in tests have to be adjusted as well, to waste a bit 
efforts.
   
   Therefore the abstract ResultPartitionWriterTestBase is proposed to 
implement the basic dummy methods for `ResultPartitionWriter`, and the previous 
four instances can all extend it to only implement one or two methods based on 
specific requirements in tests. It will probably only need to adjust the 
ResultPartitionWriterTestBase when extending the `ResultPartitionWriter` 
interface.
   
   ## Brief change log
   
     - *Introduce abstract ResultPartitionWriterTestBase to implement 
`ResultPartitionWriter`*
     - *Make previous related `ResultPartitionWriter` instances to extend 
`ResultPartitionWriterTestBase`
   
   ## Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** 
/ don't know)
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / 
don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (**not applicable** / docs / 
JavaDocs / not documented)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to