AHeise commented on a change in pull request #11441: [FLINK-16653][network][tests] Introduce ResultPartitionWriterTestBase for simplifying tests URL: https://github.com/apache/flink/pull/11441#discussion_r394319677
########## File path: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/ResultPartitionWriterTestBase.java ########## @@ -0,0 +1,92 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.io.network.partition; + +import org.apache.flink.runtime.io.network.api.writer.ResultPartitionWriter; +import org.apache.flink.runtime.io.network.buffer.BufferBuilder; +import org.apache.flink.runtime.io.network.buffer.BufferConsumer; +import org.apache.flink.util.TestLogger; + +import javax.annotation.Nullable; + +import java.io.IOException; +import java.util.concurrent.CompletableFuture; + +/** + * Basic behaviours of {@link ResultPartitionWriter} for test purpose. + */ +public abstract class ResultPartitionWriterTestBase extends TestLogger implements ResultPartitionWriter { Review comment: Finally, there is no benefit by implementing `TestLogger` since subclasses will not be used for implementing test cases. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
