[ 
https://issues.apache.org/jira/browse/FLINK-16715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17064665#comment-17064665
 ] 

Xintong Song commented on FLINK-16715:
--------------------------------------

bq. In general the whole YarnClusterDescriptor could use some refactoring (e.g. 
the startAppMaster() has ~400 lines of code).

Totally agree.

> Always use the configuration argument in YarnClusterDescriptor#startAppMaster 
> to make it more self-contained
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: FLINK-16715
>                 URL: https://issues.apache.org/jira/browse/FLINK-16715
>             Project: Flink
>          Issue Type: Improvement
>          Components: Deployment / YARN
>            Reporter: Canbin Zheng
>            Priority: Trivial
>             Fix For: 1.11.0
>
>
> In the YarnClusterDescriptor#{{startAppMaster()}} we are using some time the 
> {{configuration}} argument to the method to get/set config options, and 
> sometimes the {{flinkConfiguration}} which is a class member. This ticket 
> proposes to always use the {{configuration}} argument to make the method more 
> self-contained.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to