[
https://issues.apache.org/jira/browse/FLINK-16715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17064710#comment-17064710
]
Zili Chen commented on FLINK-16715:
-----------------------------------
> > Thanks for the work @zhengcanbin and for the review @TisonKun. I will merge
> > this.
> > Side note for a potential future JIRA: in the `startAppMaster()` method we
> > are using sometime the `configuration` argument to the method to get/set
> > config options, and sometime the `flinkConfiguration` which is a class
> > member. Shouldn't we always use the `configuration` argument? This will
> > make the method more self-contained.
>
> @kl0u yes I think I get some cycle of that problem already. However, I'd
> prefer refer to the field `flinkConfiguration`; otherwise user(previous me)
> might ask what's the difference between _this configuration object_ and _the
> one I've seen as field_? It is one of Java best practices that we don't pass
> field as parameter of this class's method.
>
> Besides, I've heard developers complain with the tight couplings between
> `YarnClusterDescriptor` and `Utils`. There are several huge & context-aware
> function. If YARN deployment is still under active development, we might
> think of refactor these codes gradually. cc @wangyang0918
cherry-pick my comment from GitHub.
> Always use the configuration argument in YarnClusterDescriptor#startAppMaster
> to make it more self-contained
> ------------------------------------------------------------------------------------------------------------
>
> Key: FLINK-16715
> URL: https://issues.apache.org/jira/browse/FLINK-16715
> Project: Flink
> Issue Type: Improvement
> Components: Deployment / YARN
> Reporter: Canbin Zheng
> Priority: Trivial
> Fix For: 1.11.0
>
>
> In the YarnClusterDescriptor#{{startAppMaster()}} we are using some time the
> {{configuration}} argument to the method to get/set config options, and
> sometimes the {{flinkConfiguration}} which is a class member. This ticket
> proposes to always use the {{configuration}} argument to make the method more
> self-contained.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
